[AMORO-3464] Add group name format validation.#3467
[AMORO-3464] Add group name format validation.#3467CosmosNi wants to merge 2 commits intoapache:masterfrom
Conversation
CosmosNi
changed the title
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
@CosmosNi thanks for the contribution, LGTM, and thanks for separating the different changes into different commits, that makes the history more clear.
two minor things: 1) could you please change the commit message of the second commit to [hotfix] and keep using English characters. 2) do you mind add some test case for this change? thanks.
|
klion26
force-pushed
the
implement_paimon_code_style
branch
from
cb51fe0 to
31de5f3
Compare
| String container = (String) map.get("container"); | ||
| Map<String, String> properties = (Map) map.get("properties"); | ||
|
|
||
| if (!ValidatorUtil.validateGroupName(name)) { |
There was a problem hiding this comment.
Do we need a extra util class?
| // use String | ||
| return StringType$.MODULE$; | ||
| case FIXED: | ||
| return BinaryType$.MODULE$; |
There was a problem hiding this comment.
This is a other minor code simplfy, I think we should raise another PR to do this
3 participants
Why are the changes needed?
Close #3464.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation