Skip to content

[AMORO-3470][Feature]:Enable catalog-level default properties storing into underlying tables within a unified catalog#3470#3479

Closed
nicochen wants to merge 0 commit intoapache:masterfrom
nicochen:master
Closed

[AMORO-3470][Feature]:Enable catalog-level default properties storing into underlying tables within a unified catalog#3470#3479
nicochen wants to merge 0 commit intoapache:masterfrom
nicochen:master

Conversation

@nicochen
Copy link
Contributor

Why are the changes needed?

Close #3470

Brief change log

  • modify create table function within link/spark unified catalog. Merges catalog-level properties which should be written into table metadata before creating table.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:common labels Mar 20, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (a34c065) to head (2878123).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/amoro/utils/MixedFormatCatalogUtil.java 89.23% 3 Missing and 4 partials ⚠️

❗ There is a different number of reports uploaded between BASE (a34c065) and HEAD (2878123). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a34c065) HEAD (2878123)
core 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3479      +/-   ##
============================================
- Coverage     27.92%   21.91%   -6.01%     
+ Complexity     3665     2407    -1258     
============================================
  Files           603      431     -172     
  Lines         49356    40533    -8823     
  Branches       6367     5745     -622     
============================================
- Hits          13783     8884    -4899     
+ Misses        34602    30899    -3703     
+ Partials        971      750     -221     
Flag Coverage Δ
core ?
trino 21.91% <89.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicochen
Copy link
Contributor Author

@zhoujinsong PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:common module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Enable catalog-level default properties storing into underlying tables within a unified catalog

2 participants

Comments