[Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large.#3521
Conversation
…e files processed by each task are not large. apache#3502
…e files processed by each task are not large. apache#3502
47bc6c9 to
8cbc056
Compare
|
Can you change the information according to the PR specification?You can refer to #3432 |
|
Thanks for the contribution! It seems that some check style error you need to fix, you can run |
xxubai
left a comment
There was a problem hiding this comment.
Can you explain this change. Why make the thread be a daemon thread
…e files processed by each task are not large. apache#3502
# Conflicts: # amoro-optimizer/amoro-optimizer-flink/src/main/java/org/apache/amoro/optimizer/flink/FlinkExecutor.java
…e files processed by each task are not large. apache#3502
This design not only ensures graceful exit during normal shutdown, but also provides an additional safety guarantee through the characteristics of daemon threads to prevent threads from preventing JVM exit under abnormal circumstances. |
For data process task, maybe user thread is a better choice? WDYT @zhoujinsong |
Setting the thread to daemon looks good to me. The process handling thread should not protect the TM from closing. |
…e files processed by each task are not large. (apache#3521) * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. apache#3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. apache#3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. apache#3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. apache#3502 --------- Co-authored-by: wardli <wardli@tencent.com> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> (cherry picked from commit 6a4f667)
…e files processed by each task are not large. (#3521) * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. #3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. #3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. #3502 * [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. #3502 --------- Co-authored-by: wardli <wardli@tencent.com> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> (cherry picked from commit 6a4f667)
Why are the changes needed?
Close #3502.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation