Skip to content

[AMORO-3633][improvement]: Fix the sorting rules of topTables order by healthScore#3634

Merged
zhoujinsong merged 2 commits intoapache:masterfrom
cxxiii:fix-toptables-sorting
Jun 26, 2025
Merged

[AMORO-3633][improvement]: Fix the sorting rules of topTables order by healthScore#3634
zhoujinsong merged 2 commits intoapache:masterfrom
cxxiii:fix-toptables-sorting

Conversation

@cxxiii
Copy link
Contributor

@cxxiii cxxiii commented Jun 25, 2025

Why are the changes needed?

Close #3633 .

Brief change log

  • Change the sorting rule of the table order by health score to compare the health scores instead of the table size.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Jun 25, 2025
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cxxiii Thanks for the contribution, LGTM

@zhoujinsong zhoujinsong merged commit 5b28138 into apache:master Jun 26, 2025
6 checks passed
Jzjsnow pushed a commit to Jzjsnow/amoro that referenced this pull request Aug 20, 2025
…y healthScore (apache#3634)

fix the sorting rules of topTables order by healthScore

(cherry picked from commit 5b28138)
zhoujinsong pushed a commit that referenced this pull request Aug 25, 2025
…y healthScore (#3634)

fix the sorting rules of topTables order by healthScore

(cherry picked from commit 5b28138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Fix the sorting rules of top tables order by health score

3 participants