[Hotfix] Replace Jersey Guava imports with Amoro shaded Guava#3674
Merged
zhoujinsong merged 1 commit intoapache:masterfrom Jul 22, 2025
Merged
[Hotfix] Replace Jersey Guava imports with Amoro shaded Guava#3674zhoujinsong merged 1 commit intoapache:masterfrom
zhoujinsong merged 1 commit intoapache:masterfrom
Conversation
xxubai
approved these changes
Jul 21, 2025
klion26
reviewed
Jul 21, 2025
| <message key="import.illegal" value="{0}; Use amoro shaded guava instead."/> | ||
| </module> | ||
|
|
||
| <module name="IllegalImport"> |
Member
There was a problem hiding this comment.
Not sure if we need to update this with Regex property on?
https://checkstyle.sourceforge.io/checks/imports/illegalimport.html#Properties
Contributor
Author
There was a problem hiding this comment.
This package may have been imported accidentally. I think IllegalImport is enough.
Of course, Regex can better detect the error introduction in the code.
If need to check for incorrect references in code, it is best to use Regex.
Contributor
|
Thanks for the contribution! @zhongqishang |
zhoujinsong
pushed a commit
that referenced
this pull request
Aug 25, 2025
Resolve conflicts in src/main/java/org/apache/amoro/server/dashboard/controller/SettingController.java (cherry picked from commit 419a947)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #xxx.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation