[Improvement] Add JDK8+ support for optimizer.sh#3702
Merged
zhoujinsong merged 1 commit intoapache:masterfrom Jul 31, 2025
Merged
[Improvement] Add JDK8+ support for optimizer.sh#3702zhoujinsong merged 1 commit intoapache:masterfrom
optimizer.sh#3702zhoujinsong merged 1 commit intoapache:masterfrom
Conversation
zhoujinsong
changed the title
optimizer.sh
zhoujinsong
approved these changes
Jul 31, 2025
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
Contributor
|
Can you help to polish ams.sh too? |
cxxiii
pushed a commit
to cxxiii/amoro
that referenced
this pull request
Jul 31, 2025
[Improvement] Add jvm parameter to optimizer.sh
zhoujinsong
added a commit
that referenced
this pull request
Aug 6, 2025
…y of Optimizer resource for Tables (#3669) * optimize the definition and function of quota * revise the calculation of occupation in scheduling policy * revise the code format * modify the default quota from a fixed value to a percentage * set the quota count to at least 1 * add an option of over quota enabled * add an option of over quota enabled correct the format * allow quota to be a decimal or a value larger than 1 * add some unit testing * update related doc * correct format * [AMORO-3638] Add support for task retries when task execution times out This commit adds a timeout for the task state `ACK`, which is helpful for that AMS can't receive the complete notification in any case. * [Improvement] Add JDK8+ support for `optimizer.sh` (#3702) [Improvement] Add jvm parameter to optimizer.sh * [Improvement] Use fileIndex="nomax" to avoid log loss. (#3701) * [AMORO-3692] Remove deprecated metrics and update related logic in MetricsSummary (#3693) [Hotfix] Remove deprecated metrics and update related logic in MetricsSummary * [AMORO-3686][Improvement]: Use ZK's multi operation to ensure write consistency. (#3687) [Improvement]: Use ZK's multi operation in HighAvailabilityContainer to ensure write consistency and fix the followerLath word spelling error #3686 Co-authored-by: wardli <wardli@tencent.com> * [AMORO-3607]Fix syntax error in init sql #3607 (#3681) * [AMORO-3245] Display comment on Table page. (#3672) * Display comment in Tables page. * fixup comment display --------- Co-authored-by: 张文领 <zhangwl9@chinatelecom.cn> * fix the bug * remove lib * polish the codes * fix error in tests * rename * rename * remove unnecessary interface method --------- Co-authored-by: Jzjsnow <snow.jiangzj@gmail.com> Co-authored-by: CatchYouIfICan <90456247+CatchYouIfICan@users.noreply.github.com> Co-authored-by: Qishang Zhong <zhongqishang@gmail.com> Co-authored-by: can <95597038+wardlican@users.noreply.github.com> Co-authored-by: wardli <wardli@tencent.com> Co-authored-by: Nico CHen <4648576+nicochen@users.noreply.github.com> Co-authored-by: zhangwl9 <1298877813@qq.com> Co-authored-by: 张文领 <zhangwl9@chinatelecom.cn> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
xxzhky
pushed a commit
to xxzhky/amoro
that referenced
this pull request
Sep 7, 2025
[Improvement] Add jvm parameter to optimizer.sh (cherry picked from commit 03131c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
[Improvement] Add jvm parameter to optimizer.sh and support jdk8+
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation