[AMORO-3691] Remove deprecated metrics and update related logic in deprectaed dependencies#3709
Merged
zhoujinsong merged 9 commits intoapache:masterfrom Aug 11, 2025
Conversation
zhoujinsong
approved these changes
Aug 4, 2025
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for this contribution!
Contributor
|
It seems there are some errors you need to fix, like in |
zhongqishang
reviewed
Aug 8, 2025
Contributor
zhongqishang
left a comment
There was a problem hiding this comment.
LGTM, I left a comment.
...-3.5/src/test/java/org/apache/amoro/spark/test/suites/sql/TestMixedFormatSessionCatalog.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3709 +/- ##
============================================
+ Coverage 28.35% 28.52% +0.17%
- Complexity 3735 3763 +28
============================================
Files 616 617 +1
Lines 49909 49953 +44
Branches 6474 6438 -36
============================================
+ Hits 14150 14250 +100
+ Misses 34750 34689 -61
- Partials 1009 1014 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhongqishang
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Removes deprecated dependencies and updates corresponding logic.
Close #3691.
Brief change log
Removes deprected in :
org.apache.amoro.table.TableProperties
org.apache.amoro.properties.CatalogMetaProperties
ARCTIC related
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation