Skip to content

[AMORO-3691] Remove deprecated metrics and update related logic in deprectaed dependencies#3709

Merged
zhoujinsong merged 9 commits intoapache:masterfrom
SalvadorRomo:remove-deprectaed-dependencies
Aug 11, 2025
Merged

[AMORO-3691] Remove deprecated metrics and update related logic in deprectaed dependencies#3709
zhoujinsong merged 9 commits intoapache:masterfrom
SalvadorRomo:remove-deprectaed-dependencies

Conversation

@SalvadorRomo
Copy link
Contributor

@SalvadorRomo SalvadorRomo commented Aug 3, 2025

Why are the changes needed?

Removes deprecated dependencies and updates corresponding logic.

Close #3691.

Brief change log

Removes deprected in :

org.apache.amoro.table.TableProperties
org.apache.amoro.properties.CatalogMetaProperties
ARCTIC related

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format module:common labels Aug 3, 2025
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for this contribution!

@zhoujinsong
Copy link
Contributor

It seems there are some errors you need to fix, like in TestMixedFormatSessionCatalog.java:165.

@github-actions github-actions bot added the module:mixed-spark Spark module for Mixed Format label Aug 5, 2025
Copy link
Contributor

@zhongqishang zhongqishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a comment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.52%. Comparing base (02a2c1f) to head (c6abcb2).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/amoro/utils/CompatiblePropertyUtil.java 20.00% 4 Missing ⚠️
...e/amoro/hive/utils/CompatibleHivePropertyUtil.java 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3709      +/-   ##
============================================
+ Coverage     28.35%   28.52%   +0.17%     
- Complexity     3735     3763      +28     
============================================
  Files           616      617       +1     
  Lines         49909    49953      +44     
  Branches       6474     6438      -36     
============================================
+ Hits          14150    14250     +100     
+ Misses        34750    34689      -61     
- Partials       1009     1014       +5     
Flag Coverage Δ
core 28.52% <20.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhoujinsong zhoujinsong merged commit 45313a0 into apache:master Aug 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:common module:mixed-hive Hive moduel for Mixed Format module:mixed-spark Spark module for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants