Skip to content

[AMORO-3552] Optimize binary distribution NOTICE&LICENSE file #3743

Merged
zhoujinsong merged 3 commits intoapache:masterfrom
zhoujinsong:fix-licence-notice
Aug 26, 2025
Merged

[AMORO-3552] Optimize binary distribution NOTICE&LICENSE file #3743
zhoujinsong merged 3 commits intoapache:masterfrom
zhoujinsong:fix-licence-notice

Conversation

@zhoujinsong
Copy link
Contributor

Why are the changes needed?

Close #3552.

Brief change log

  • as titled.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoujinsong thanks for the contribution, left some inline comments, please let me know what you think about it.

NOTICE-binary Outdated
Apache Commons Lang
Copyright 2001-2024 The Apache Software Foundation

Apache Commons Pool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, we don't need to mention the ASF project here?

- binary distribution NOTICE should content the NOTICE from ALv2
project (non ASF), for instance Jackson, AWS SDK, Netty, etc. That
would be great to double check that for next releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we can remove the ASF project listed in the NOTICE file

- NOTICE is OK. Nit: the NOTICE can be lighter: no need to mention the
ASF projects here (Iceberg, Paimon, Flink)

Copy link
Contributor Author

@zhoujinsong zhoujinsong Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is fine to exclude the ASF projects, but I still prefer to include it here, like many other projects did:

Besides, some projects did not like:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either way, but as the asf website said, so maybe removing the ASF project here is better.

It is important to keep NOTICE as brief and simple as possible, as each addition places a burden on downstream consumers.

**Do not** add anything to NOTICE which is not legally required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, I will remove the ASF projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klion26 I have removed the ASF projects here, PTAL.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoujinsong thanks for the update, LGTM

@zhoujinsong zhoujinsong merged commit e3c16af into apache:master Aug 26, 2025
1 check passed
@zhoujinsong zhoujinsong deleted the fix-licence-notice branch August 26, 2025 02:07
klion26 pushed a commit that referenced this pull request Aug 26, 2025
klion26 pushed a commit that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: optimize binary distribution NOTICE

2 participants