[AMORO-3552] Optimize binary distribution NOTICE&LICENSE file #3743
[AMORO-3552] Optimize binary distribution NOTICE&LICENSE file #3743zhoujinsong merged 3 commits intoapache:masterfrom
Conversation
klion26
left a comment
There was a problem hiding this comment.
@zhoujinsong thanks for the contribution, left some inline comments, please let me know what you think about it.
NOTICE-binary
Outdated
| Apache Commons Lang | ||
| Copyright 2001-2024 The Apache Software Foundation | ||
|
|
||
| Apache Commons Pool |
There was a problem hiding this comment.
IIUC, we don't need to mention the ASF project here?
- binary distribution NOTICE should content the NOTICE from ALv2
project (non ASF), for instance Jackson, AWS SDK, Netty, etc. That
would be great to double check that for next releases.
There was a problem hiding this comment.
And we can remove the ASF project listed in the NOTICE file
- NOTICE is OK. Nit: the NOTICE can be lighter: no need to mention the
ASF projects here (Iceberg, Paimon, Flink)
There was a problem hiding this comment.
Yes, it is fine to exclude the ASF projects, but I still prefer to include it here, like many other projects did:
- https://github.com/apache/gravitino/blob/main/NOTICE.bin
- https://github.com/apache/spark/blob/master/NOTICE-binary
Besides, some projects did not like:
There was a problem hiding this comment.
I'm fine with either way, but as the asf website said, so maybe removing the ASF project here is better.
It is important to keep NOTICE as brief and simple as possible, as each addition places a burden on downstream consumers.
**Do not** add anything to NOTICE which is not legally required.
There was a problem hiding this comment.
Make sense to me, I will remove the ASF projects.
There was a problem hiding this comment.
@klion26 I have removed the ASF projects here, PTAL.
klion26
left a comment
There was a problem hiding this comment.
@zhoujinsong thanks for the update, LGTM
Why are the changes needed?
Close #3552.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation