Skip to content

[AMORO-3817] Don't close fileIO when cleaning orphan files#3820

Merged
zhoujinsong merged 1 commit intoapache:masterfrom
xxubai:retain-orphan-cleaning-fileio
Oct 23, 2025
Merged

[AMORO-3817] Don't close fileIO when cleaning orphan files#3820
zhoujinsong merged 1 commit intoapache:masterfrom
xxubai:retain-orphan-cleaning-fileio

Conversation

@xxubai
Copy link
Contributor

@xxubai xxubai commented Oct 14, 2025

Why are the changes needed?

Close #3817.

Brief change log

  • Avoid using the closed fileIO when cleaning orphan metadata files

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Oct 14, 2025
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit b3db8b8 into apache:master Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The shared fileIO object was mistakenly closed during orphan file cleanup.

2 participants