[AMORO-4130][amoro-web] Replace hardcoded frontend texts with i18n translations#4133
Open
Bingtagui404 wants to merge 1 commit intoapache:masterfrom
Open
[AMORO-4130][amoro-web] Replace hardcoded frontend texts with i18n translations#4133Bingtagui404 wants to merge 1 commit intoapache:masterfrom
Bingtagui404 wants to merge 1 commit intoapache:masterfrom
Conversation
将 5 个 Vue 文件中的硬编码英文文本替换为 vue-i18n 调用， 并在 en.ts/zh.ts 中添加 11 个新翻译键。 涉及的硬编码文本包括： - placeholder: Optimizer group, Action, Type, Status - form label: Catalog, Database, Table, Type, Endpoint, Region, Hadoop Username, Kerberos Principal, Access Key, Secret Key - 展示文本: Charts, All - 列副标题: success / total, size / count
Contributor
|
Bump @zhangmo8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The amoro-web frontend uses vue-i18n and shared helpers like usePlaceholder(), but several pages still contain hardcoded English labels, placeholders, and texts, making the UI inconsistent and harder to localize.
Fixes #4130
Reproduction
Switch the UI language to Chinese — hardcoded texts like "Optimizer group", "Action", "Type", "Status", "Catalog", "Database", "Table", "Charts", "All", "Endpoint", "Region", "Hadoop Username", "Kerberos Principal", "Access Key", "Secret Key", "success / total", and "size / count" remain in English.
Fix Scope
Replaced all hardcoded user-facing texts in the 5 files listed in #4130 with vue-i18n calls ($t / t), reusing existing translation keys where possible (e.g. optimizerGroup, type, status, catalog, database, table) and adding 11 new keys (action, all, charts, endpoint, region, hadoopUsername, kerberosPrincipal, accessKey, secretKey, successSlashTotal, sizeSlashCount) to both en.ts and zh.ts. 7 files changed, 46 insertions, 24 deletions.
Test Evidence
Static code review passed (reviewed twice — first round caught missing strings, second round confirmed all resolved).
git diff --check HEAD~1passed. No runtime test executed (frontend build environment not set up locally).Known Limitations
Only covers the 5 Vue files explicitly listed in #4130. Other files in amoro-web may still contain hardcoded texts. No runtime language-switching verification was performed.