[AMORO-4162] Upgrade Iceberg dependency from 1.6.1 to 1.7.2#4163
Merged
czy006 merged 4 commits intoapache:masterfrom Apr 7, 2026
Merged
[AMORO-4162] Upgrade Iceberg dependency from 1.6.1 to 1.7.2#4163czy006 merged 4 commits intoapache:masterfrom
czy006 merged 4 commits intoapache:masterfrom
Conversation
9b10e14 to
e2a8720
Compare
47121d3 to
3437084
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4163 +/- ##
============================================
- Coverage 29.93% 29.65% -0.29%
- Complexity 4229 4246 +17
============================================
Files 675 677 +2
Lines 53990 54690 +700
Branches 6838 6960 +122
============================================
+ Hits 16161 16216 +55
- Misses 36636 37268 +632
- Partials 1193 1206 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
132ddcd to
52f3da8
Compare
Bump iceberg.version in root pom.xml and update dependency manifests and documentation references. Notable transitive dependency changes: - Avro 1.11.3 → 1.12.0 - httpclient5 5.3.1 → 5.4, httpcore5 5.2.4 → 5.3 - New: failsafe 3.3.2 Signed-off-by: Jiwon Park <jpark92@outlook.kr>
- Migrate WriteResult → FlinkWriteResult in Flink sink pipeline - Add FieldGetter[] parameter to RowDataUtil.clone() in RowDataRecordFactory - Migrate PruneColumns from ParquetTypeVisitor to TypeWithSchemaVisitor - Fix INT96 timestamp min/max statistics byte-order inversion - Fork MiniClusterResource (removed in Iceberg 1.7.0) into test package - Update MiniClusterResource imports in all test classes Signed-off-by: Jiwon Park <jpark92@outlook.kr>
- TestAdaptHiveParquetSchemaUtil: verify pruneColumns with TypeWithSchemaVisitor correctly prunes columns using expected schema - TestAdaptHiveParquetUtil: verify INT96 timestamp min/max statistics are correctly re-ordered when byte-wise ordering disagrees with chronological ordering Signed-off-by: Jiwon Park <jpark92@outlook.kr>
52f3da8 to
0f6c595
Compare
xxubai
approved these changes
Apr 7, 2026
Contributor
xxubai
left a comment
There was a problem hiding this comment.
LGTM overall. The Iceberg 1.7.2 adaptation looks consistent.
| Literal<?> min; | ||
| Literal<?> max; | ||
| @SuppressWarnings("unchecked") | ||
| java.util.Comparator<Object> cmp = (java.util.Comparator<Object>) val1.comparator(); |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| java.util.Comparator<Object> cmp = (java.util.Comparator<Object>) val1.comparator(); | |
| Comparator<Object> cmp = (Comparator<Object>) val1.comparator(); |
zhoujinsong
approved these changes
Apr 7, 2026
Contributor
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM overall.
Thanks a lot for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Resolve #4162.
Stepping stone toward Iceberg 1.10.1, picking up bug fixes
Brief change log
iceberg.version1.6.1 → 1.7.2 in rootpom.xmlFlinkWriteResultAPI change in Flink sink pipelinePruneColumnsfromParquetTypeVisitortoTypeWithSchemaVisitorinAdaptHiveParquetSchemaUtilFieldGetter[]parameter toRowDataUtil.clone()call inRowDataRecordFactoryMiniClusterResource(removed in Iceberg 1.7.0) intoorg.apache.amoro.flinktest packageAdaptHiveParquetUtil— Parquet byte-order ≠ chronological orderHow was this patch tested?
amoro-format-iceberg,amoro-mixed-flink-common,amoro-mixed-hive: PASSTestDataExpire(216 tests),TestDataExpireHive(48 tests): PASSTestSnapshotExpire,TestSnapshotExpireHive,TestSnapshotExpireIceberg,TestDataExpireIceberg: PASSDocumentation