Skip to content

Replace fully qualified Comparator reference with simple class name in AdaptHiveParquetUtil#4170

Merged
xxubai merged 1 commit into
apache:masterfrom
j1wonpark:fix/adapt-hive-parquet-util-import-cleanup
Apr 9, 2026
Merged

Replace fully qualified Comparator reference with simple class name in AdaptHiveParquetUtil#4170
xxubai merged 1 commit into
apache:masterfrom
j1wonpark:fix/adapt-hive-parquet-util-import-cleanup

Conversation

@j1wonpark
Copy link
Copy Markdown
Contributor

Why are the changes needed?

Replace fully qualified java.util.Comparator references with simple class name for better readability and consistency with other imports in the file.

Brief change log

  • Added import java.util.Comparator to AdaptHiveParquetUtil.java
  • Replaced inline java.util.Comparator<Object> with Comparator<Object>

How was this patch tested?

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions Bot added module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format type:infra module:common labels Apr 8, 2026
@j1wonpark j1wonpark changed the title [hotfix] Replace fully qualified Comparator reference with simple class name in AdaptHiveParquetUtil Replace fully qualified Comparator reference with simple class name in AdaptHiveParquetUtil Apr 8, 2026
@j1wonpark j1wonpark closed this Apr 8, 2026
@j1wonpark j1wonpark deleted the fix/adapt-hive-parquet-util-import-cleanup branch April 8, 2026 07:27
@j1wonpark j1wonpark restored the fix/adapt-hive-parquet-util-import-cleanup branch April 8, 2026 07:28
@j1wonpark j1wonpark reopened this Apr 8, 2026
@j1wonpark j1wonpark force-pushed the fix/adapt-hive-parquet-util-import-cleanup branch from c58752a to e6aff93 Compare April 8, 2026 07:45
…lass name in AdaptHiveParquetUtil

Signed-off-by: Jiwon Park <jpark92@outlook.kr>
@j1wonpark j1wonpark force-pushed the fix/adapt-hive-parquet-util-import-cleanup branch from e6aff93 to 20c15c0 Compare April 8, 2026 07:50
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.65%. Comparing base (fe98a6c) to head (20c15c0).
⚠️ Report is 15 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (fe98a6c) and HEAD (20c15c0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fe98a6c) HEAD (20c15c0)
core 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4170      +/-   ##
============================================
- Coverage     29.93%   22.65%   -7.28%     
+ Complexity     4229     2612    -1617     
============================================
  Files           675      461     -214     
  Lines         53990    42520   -11470     
  Branches       6838     5994     -844     
============================================
- Hits          16161     9634    -6527     
+ Misses        36636    32049    -4587     
+ Partials       1193      837     -356     
Flag Coverage Δ
core ?
trino 22.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xxubai xxubai merged commit 67feed8 into apache:master Apr 9, 2026
6 of 9 checks passed
@j1wonpark j1wonpark deleted the fix/adapt-hive-parquet-util-import-cleanup branch April 17, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:mixed-hive Hive moduel for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants