[AMORO-4190][ams] Graceful handling of catalog initialization failures in DefaultCatalogManager#4189
Merged
Conversation
… DefaultCatalogManager - Wrap individual catalog loading in try-catch during initialization so that a single catalog failure is logged and skipped rather than crashing AMS - When a catalog is not present in serverCatalogMap (failed to initialize), fall back to updating DB directly and attempt to rebuild with the new metadata - Add tests verifying both initialization resilience and update recovery Signed-off-by: Jiwon Park <jpark92@outlook.kr>
j1wonpark
force-pushed
the
catalog-init-failure-recovery
branch
from
1ef4556 to
5585847
Compare
j1wonpark
changed the title
czy006
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
resolve #4190
Brief change log
DefaultCatalogManager: Wrap individual catalog loading in try-catch during initialization so that a single catalog failure is logged and skipped rather than crashing AMSDefaultCatalogManager.updateCatalog(): When a catalog is not present inserverCatalogMap(failed to initialize), fall back to updating DB directly and attempt to rebuild with the new metadata, allowing operators to fix catalog configuration from the dashboard without restarting AMSDefaultCatalogManager.removeServerCatalog(): Add@VisibleForTestinghelper method for test supportTestDefaultCatalogManagerRecovery: Add tests verifying both initialization resilience and update recovery for failed catalogsHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
testInitializationSkipsFailedCatalog: Verifies thatDefaultCatalogManagerconstructor does not throw when a REST catalog with an unreachable endpoint exists in the databasetestUpdateCatalogThatFailedToInitialize: Verifies thatupdateCatalog()succeeds for a catalog that exists in DB but failed to load intoserverCatalogMapRun test locally before making a pull request
Documentation