fix: attachment upload broken after v2.0.0 upgrade (#1525)#1527
Merged
Conversation
- base.ts: add replaceRange method to CodeMirror adapter - file.tsx: use replaceSelection to insert loading text (fixes RangeError) - file.tsx: use useState/useEffect for stable editorState reference in async callbacks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
robinv8
force-pushed
the
fix/issue-1525-attachment-upload
branch
from
b99762e to
94c6c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1525. After upgrading to v2.0.0, file attachment uploads fail with:
Root Cause
file.tsxupload success handler calledreplaceRange('', startPos, endPos)to remove the loading placeholder, thenreplaceSelection(text)to insert the result. AfterreplaceRangeremoves the text, the cursor position shifts, soreplaceSelectioninserts at the wrong location. More critically,replaceRangealso requires the target range to exist in the document — if called with a staleendPosthat's out of bounds, it throws aRangeError.Fix
base.ts: Add missingreplaceRangemethod to the CodeMirror adapterfile.tsx: ReplacereplaceRange('', ...) + replaceSelection(text)with a singlereplaceRange(text, startPos, endPos)call — atomically replaces the loading placeholder with the final link in one operation