This repository was archived by the owner on Jul 3, 2023. It is now read-only.
[ANY23-371] Any23 cannot start in CMD in Windows 10 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@afs can you please check? I can't and wouldn't even trust the outcome if I did. I have not used Windows OS for a long time. Thank you both :) |
Member
|
Sorry, I don't have a Windows machine. |
Member
|
I've verified that this does not break compatibility on macOS. Going to merge into master branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long classpath is a known issue in the maven plug-in appassembler-maven-plugin. The description of the issue is here:
https://www.mojohaus.org/appassembler/appassembler-maven-plugin/faq.html#
This pull request solved this issue by implementing the "Booter" mechanism, which is described here:
https://www.mojohaus.org/appassembler/appassembler-maven-plugin/usage-booter.html
The generated any23.bat does not contain the long "set CLASSPATH=..." any more. The generated script runs on CMD even if the base path is very long.