This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Fix generation of BNode name for microdata when 'itemid' is given without a value.#9
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 16, 2014
Merged
Conversation
without a value. Was using the MD5 of "0" resulting in lots of BNodes called 'nodecfcd208495d565ef66e7dff9f98764da' Fix ToolRunnerTest to check for no tools.
Member
|
Hi @Timpy thank you so much fo this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generation of BNode name for microdata when 'itemid' is given with an empty value.
This results in using the MD5 of "0" in the name of BNodes: 'nodecfcd208495d565ef66e7dff9f98764da'
An example of where this is a problem is https://www.youtube.com/channel/UCQNIKO3SwRcYnoiuSqKYbOA
'
Also added a check to ToolRunnerTest for no tools.