This repository was archived by the owner on May 12, 2021. It is now read-only.
APEXMALHAR-2305 #resolve Mirror the proto-session window behavior des…#458
Merged
asfgit merged 2 commits intoapache:masterfrom Oct 19, 2016
Merged
APEXMALHAR-2305 #resolve Mirror the proto-session window behavior des…#458asfgit merged 2 commits intoapache:masterfrom
asfgit merged 2 commits intoapache:masterfrom
Conversation
siyuanh
reviewed
Oct 19, 2016
| // create a new session window that covers the timestamp | ||
| long newBeginTimestamp = Math.min(sessionWindow.getBeginTimestamp(), timestamp); | ||
| long newEndTimestamp = Math.max(sessionWindow.getBeginTimestamp() + sessionWindow.getDurationMillis(), timestamp + 1); | ||
| long newEndTimestamp = Math.max(sessionWindow.getBeginTimestamp() + sessionWindow.getDurationMillis(), timestamp + minGapMillis); |
Contributor
There was a problem hiding this comment.
I personally feel wrap the logic into a method like getEndTimestamp(), getProtoEndTimestamp() and extendTo(long time) would be more readable
Contributor
|
Looks good, probably just reopen the PR to make travis/Jenkins happy? |
davidyan74
force-pushed
the
APEXMALHAR-2305
branch
from
ffebaee to
44e59c0
Compare
added 2 commits
October 19, 2016 12:36
…cribed in the streaming 102 blog
siyuanh
force-pushed
the
APEXMALHAR-2305
branch
from
44e59c0 to
2cf8bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cribed in the streaming 102 blog
@siyuanh please review and merge