Skip to content

Conversation

@imjoey
Copy link
Member

@imjoey imjoey commented Feb 7, 2021

Co-authored-by: litesun 7sunmiao@gmail.com

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Backport patches

  • Why need to backport?
    2.3 is the version of APISIX that matches the upcoming release 2.4 of dashboard, we need this PR for sync the JSON schema within APISIX 2.3.

  • Source branch
    master

  • Related commits and pull requests
    commit: 5348579
    PR: chore: sync JSON Schema from APISIX version 2.3 #1445

  • Target branch
    v2.4

Co-authored-by: litesun <7sunmiao@gmail.com>
@imjoey imjoey changed the base branch from master to v2.4 February 7, 2021 10:56
@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #1453 (869d036) into v2.4 (8796fa1) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             v2.4    #1453      +/-   ##
==========================================
+ Coverage   67.61%   67.91%   +0.29%     
==========================================
  Files          48       48              
  Lines        3042     3042              
==========================================
+ Hits         2057     2066       +9     
+ Misses        741      733       -8     
+ Partials      244      243       -1     
Impacted Files Coverage Δ
api/internal/core/store/store.go 86.14% <0.00%> (-0.61%) ⬇️
api/internal/core/store/storehub.go 74.48% <0.00%> (+4.08%) ⬆️
api/internal/core/storage/etcd.go 49.09% <0.00%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8796fa1...869d036. Read the comment docs.

@imjoey imjoey requested review from LiteSun and liuxiran February 7, 2021 11:22
@liuxiran liuxiran merged commit 37492e4 into apache:v2.4 Feb 7, 2021
@imjoey imjoey deleted the backport_1445_to_v2_4 branch February 7, 2021 11:25
@imjoey imjoey added the backport label Feb 7, 2021
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (8796fa1) to head (869d036).
Report is 7 commits behind head on v2.4.

Additional details and impacted files
@@            Coverage Diff             @@
##             v2.4    #1453      +/-   ##
==========================================
+ Coverage   67.61%   67.91%   +0.29%     
==========================================
  Files          48       48              
  Lines        3042     3042              
==========================================
+ Hits         2057     2066       +9     
+ Misses        741      733       -8     
+ Partials      244      243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants