Skip to content

Conversation

@bisakhmondal
Copy link
Member

Why submit this pull request?

  • docs

What changes will this PR take into?

Users guide.

Related issues
closes #842

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 10, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 4d6f572

https://deploy-preview-1885--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member

It seems that this PR gets pending due to CI issues...

Copy link
Contributor

@iamayushdas iamayushdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@bisakhmondal
Copy link
Member Author

bisakhmondal commented May 11, 2021

It seems that this PR gets pending due to CI issues...

Any guess why? let me check with a blank commit.

Also there is no GitHub logo for those two CI.

@juzhiyuan
Copy link
Member

@bisakhmondal Hi, would you help to ask GitHub support for more information?

@bisakhmondal
Copy link
Member Author

@bisakhmondal Hi, would you help to ask GitHub support for more information?

Hi, I have opened a fresh ticket through GitHub support. I'll keep you posted about any new updates.
Thanks :)

@bisakhmondal
Copy link
Member Author

Hi @juzhiyuan, got a reply from GitHub support.
image

Sounds good, isn't it. It seems we overthought, haha😄
Both of them has path-ignore set to docs/** :)

@bisakhmondal bisakhmondal mentioned this pull request May 23, 2021
4 tasks
@imjoey
Copy link
Member

imjoey commented May 24, 2021

@bisakhmondal @juzhiyuan The CI issue is due to set both Frontend e2e test and run-test as required checks. Apache Infra team has already fixed this, see https://issues.apache.org/jira/browse/INFRA-21906 for detail. We can merge this now.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks.

@imjoey imjoey merged commit d2232e1 into apache:master May 24, 2021
@bisakhmondal
Copy link
Member Author

@bisakhmondal @juzhiyuan The CI issue is due to set both Frontend e2e test and run-test as required checks. Apache Infra team has already fixed this, see https://issues.apache.org/jira/browse/INFRA-21906 for detail. We can merge this now.

Awesome @imjoey. Great work :) Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support run manager api as OS service

6 participants