Skip to content

Conversation

@imjoey
Copy link
Member

@imjoey imjoey commented Sep 1, 2021

Signed-off-by: imjoey majunjie@apache.org

Please answer these questions before submitting a pull request, or your PR will get closed.

Since #2109 does not completely resolve #2108, this is another solution. This PR is going to create new builder, instead of the default one, to support cache and many other features. See https://docs.docker.com/engine/reference/commandline/buildx_create/ for details.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

Fixes #2108.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: imjoey <majunjie@apache.org>
@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 17aa912

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612f4781ce7fb80007fcdfd9

😎 Browse the preview: https://deploy-preview-2112--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

Codecov Report

Merging #2112 (17aa912) into master (9450979) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2112   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files         124      124           
  Lines        3279     3279           
  Branches      799      799           
=======================================
  Hits         2208     2208           
  Misses       1071     1071           
Flag Coverage Δ
frontend-e2e-test 67.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9450979...17aa912. Read the comment docs.

@imjoey
Copy link
Member Author

imjoey commented Sep 1, 2021

ping @bzp2010 @starsz for review. Thanks.

@starsz starsz merged commit 528699d into apache:master Sep 2, 2021
@imjoey imjoey deleted the fix/ci_buildx_2 branch September 2, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: master ci failed with buildx failed error

5 participants