feat: bump APISIX Dashboard to 2.10#254
Conversation
|
Hi, all. PTAL, however, it should be noted that these modifications cannot be tested by CI, and CI can only be triggered by |
bzp2010
changed the title
Please don't merge for now, I can't get the local build test to pass correctly. |
bzp2010
force-pushed
the
feat-bump-dashboard-2100
branch
from
f678f1e to
6a24a39
Compare
|
LGTM， Can we merge this feature now？ |
|
Hi,@gxthrj. Docker buildx used in this PR uses the QEMU analog ARM instruction mode to compile the GO program and NodeJS, which will result in serious performance issues, I am working on it (using cross-compilation and fixing It still needs to be waited for a while, and about it will be prepared to merge it tomorrow. |
UpdateI've done a local test of multi-architecture packaging and it completes in about 10 minutes or so [demo], outputting Othercc @gxthrj @nic-chen @starsz I'm sorry for making some more changes after the review, I fixed the build taking too long, please take a look again. |
| push-multiarch-dashbaord: | ||
| @$(call func_echo_status, "$@ -> [ Start ]") | ||
| $(ENV_DOCKER) buildx build --push \ | ||
| -t $(APISIX_DASHBOARD_IMAGE_NAME):$(APISIX_DASHBOARD_VERSION) \ |
There was a problem hiding this comment.
I suggest to add multiarch to image name.
| RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w GOPROXY=https://goproxy.io,direct ; fi \ | ||
| && go env -w GO111MODULE=on \ | ||
| && CGO_ENABLED=0 ./api/build.sh | ||
| && CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} ./api/build.sh |
There was a problem hiding this comment.
we could put GOOS and GOARCH into build.sh later.
| RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w GOPROXY=https://goproxy.io,direct ; fi \ | ||
| && go env -w GO111MODULE=on \ | ||
| && CGO_ENABLED=0 ./api/build.sh | ||
| && CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} ./api/build.sh |
There was a problem hiding this comment.
we could put GOOS and GOARCH into build.sh later.
5 participants
Upgrade the latest version of APISIX Dashbaord 2.10 while supporting multi-architecture build and push.