fix: add etcdctl binary when use_grpc #400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengxsong <fengxsong@outlook.com>
fengxsong
force-pushed
the
add_etcdctl_when_use_grpc
branch
from
f4bc119 to
c729018
Compare
spacewander
reviewed
Jan 6, 2023
Member
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
The etcdctl is packed in
https://github.com/api7/apisix-build-tools/blob/7fbbde6bdbd5b1c6404a5c610b38be5344503e6f/build-apisix-base.sh#L186
And we already have code to check the existence of etcdctl:
https://github.com/apache/apisix/blob/1609ce6990b6d93262ea80efb29836eab2109c0e/apisix/cli/etcd.lua#L487
Could you provide a stand-alone example to reproduce this issue?
Contributor
Author
|
when using image root@10.74.36.168:~# kubectl -n ingress-apisix logs -f apisix-5cd9bf77db-lqx9w
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init
WARNING: using fixed Admin API token has security risk.
Please modify "admin_key" in conf/config.yaml .
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init_etcd
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found
sh: 1: etcdctl: not found |
Contributor
Author
|
All right, looks like the root@10:/usr/local/apisix# find / -name 'etcd*'
find: '/proc/63/map_files': Permission denied
find: '/proc/64/map_files': Permission denied
find: '/proc/65/map_files': Permission denied
find: '/proc/66/map_files': Permission denied
find: '/proc/67/map_files': Permission denied
/usr/local/apisix/apisix/cli/etcd.lua
/usr/local/apisix/apisix/core/etcd.lua
/usr/local/apisix/deps/share/lua/5.1/resty/etcd
/usr/local/apisix/deps/share/lua/5.1/resty/etcd.lua
/usr/local/openresty/bin/etcdctl
/etcd-ssl
root@10:/usr/local/apisix# echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/binI'll make another PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fengxsong fengxsong@outlook.com
When
etcd.use_grpc=true, withoutetcdctlbinary tool apisix willcrash infinitereport error.In order to build multi-arch images, use multistage build.