Skip to content

Conversation

@soulbird
Copy link
Contributor

We will add response.go and Response interface to support response phase

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #88 (fb1cec7) into master (413b903) will decrease coverage by 1.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   81.23%   79.49%   -1.75%     
==========================================
  Files          11       12       +1     
  Lines         746      746              
==========================================
- Hits          606      593      -13     
- Misses        102      114      +12     
- Partials       38       39       +1     
Impacted Files Coverage Δ
internal/http/request.go 93.36% <ø> (-0.14%) ⬇️
internal/http/header.go 100.00% <100.00%> (ø)
internal/http/req-response.go 100.00% <100.00%> (ø)
internal/plugin/plugin.go 78.68% <100.00%> (ø)
internal/server/server.go 56.91% <0.00%> (-10.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413b903...fb1cec7. Read the comment docs.

spacewander
spacewander previously approved these changes Jun 16, 2022
spacewander
spacewander previously approved these changes Jun 17, 2022
@spacewander
Copy link
Member

Please make the CI pass, thanks!

@spacewander spacewander merged commit 97f8464 into apache:master Jun 17, 2022
@spacewander spacewander mentioned this pull request Jun 22, 2022
MrLYC pushed a commit to MrLYC/apisix-go-plugin-runner that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants