feat: support for using apisix 3.x image #390
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzssangglass
commented
Nov 9, 2022
| # limitations under the License. | ||
|
|
||
| {{- $isBeta := (semverCompare ">=2.99.0" .Values.apisix.image.tag) }} | ||
| {{- $isBeta := (semverCompare ">=2.99.0-debian" .Values.apisix.image.tag) }} |
Member
Author
There was a problem hiding this comment.
>=2.99.0-debian is a bad syntax, I will try to update it.
docs/en/latest/apisix.md
Outdated
|
|
||
| :::note | ||
|
|
||
| apisix-ingress-controller is not compatible with APISIX 3.x. |
Member
There was a problem hiding this comment.
the dashboard is also not compatible with APISIX 3.x, right?
Member
Author
work around with |
tokers
reviewed
Nov 9, 2022
docs/en/latest/apisix.md
Outdated
|
|
||
| ### APISIX v3.x | ||
|
|
||
| The current default version of APISIX installed is 2.15.0, if you want to install APISIX 3.x, to install the chart of APISIX with: |
Contributor
There was a problem hiding this comment.
Suggested change
| The current default version of APISIX installed is 2.15.0, if you want to install APISIX 3.x, to install the chart of APISIX with: | |
| The current default version of APISIX installed is `2.15.0`, if you want to install APISIX 3.x, to install the chart of APISIX with: |
docs/en/latest/apisix.md
Outdated
|
|
||
| :::note | ||
|
|
||
| APISIX-Ingress-Controller and APISIX Dashboard are not compatible with APISIX 3.x. |
Contributor
There was a problem hiding this comment.
Suggested change
| APISIX-Ingress-Controller and APISIX Dashboard are not compatible with APISIX 3.x. | |
| The latest APISIX Ingress Controller and APISIX Dashboard are not compatible with APISIX 3.x. |
Member
Author
|
note that the |
tokers
approved these changes
Nov 10, 2022
tao12345666333
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #389