Skip to content

Conversation

@Firstsawyou
Copy link
Contributor

@Firstsawyou Firstsawyou commented May 24, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Bugfix

  • Description

close #473

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #486 (301b2e1) into master (bc71e3e) will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   37.00%   37.42%   +0.41%     
==========================================
  Files          47       47              
  Lines        3845     3845              
==========================================
+ Hits         1423     1439      +16     
+ Misses       2237     2223      -14     
+ Partials      185      183       -2     
Impacted Files Coverage Δ
pkg/apisix/route.go 35.29% <0.00%> (+2.20%) ⬆️
pkg/apisix/cluster.go 32.20% <0.00%> (+5.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc71e3e...301b2e1. Read the comment docs.

@Firstsawyou Firstsawyou marked this pull request as ready for review May 24, 2021 14:30
@Firstsawyou
Copy link
Contributor Author

@tokers @gxthrj @tao12345666333 Please take a look.

@gxthrj gxthrj merged commit 92896f1 into apache:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: e2e case for tcp proxy is unstable

4 participants