Skip to content

Conversation

@gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Sep 2, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

@codecov-commenter
Copy link

Codecov Report

Merging #660 (4daccce) into master (75a2aaa) will increase coverage by 0.04%.
The diff coverage is 45.83%.

❗ Current head 4daccce differs from pull request most recent head da4598d. Consider uploading reports for the commit da4598d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   34.72%   34.77%   +0.04%     
==========================================
  Files          60       60              
  Lines        5892     5916      +24     
==========================================
+ Hits         2046     2057      +11     
- Misses       3596     3608      +12     
- Partials      250      251       +1     
Impacted Files Coverage Δ
pkg/apisix/apisix.go 67.50% <ø> (ø)
pkg/apisix/nonexistentclient.go 42.42% <0.00%> (-2.03%) ⬇️
pkg/kube/translation/apisix_route.go 26.57% <41.66%> (+0.41%) ⬆️
pkg/apisix/schema.go 63.26% <100.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a832c...da4598d. Read the comment docs.


docker pull busybox:1.28
docker tag busybox:1.28 $(LOCAL_REGISTRY)/busybox:1.28
docker push $(LOCAL_REGISTRY)/busybox:1.28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to modify helm chart.

@tao12345666333
Copy link
Member

Let's go forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants