feat: support deploy jar to the Maven Central repository #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tzssangglass
approved these changes
Jun 29, 2022
Member
|
LGTM. I will give this PR a validation as soon as possible and then add MAINTAIN.md and the corresponding CI (I hope the push jar can be done in the CI) |
tzssangglass
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is an updated version of a previously closed PR (#153) that I cluttered with poor commits. Apologies for cluttering the list of Closed PRs.
New feature or improvement
Updated pom.xml files to allow deployment of JAR to Maven Central Repository. This will allow users to download the JAR from the Maven Repository and build their plugins without having to clone the source code.
I have deployed a test JAR to Maven Central (https://search.maven.org/search?q=io.github.ericluoliu) under my GAV coordinates, and I have used this JAR by referencing it as a dependency in pom.xml to build a functional (end-to-end) demo plugin in a new Java SpringBoot project.
-Source branch: deployJAR branch on https://github.com/ericluoliu/apisix-java-plugin-runner
-Related commits and pull requests: N/A
-Target branch: main branch on https://github.com/apache/apisix-java-plugin-runner