request help: add service_id as key to plugin limit-*

[LY-GO]

Issue description

i want to add key for limit-plugin;it can accomplish limit according to service_id;If i want to implement the function,you can give some suggestion.Thanks!

Environment

• apisix version (cmd: apisix version):
• OS:

[membphis]

1. you need to use a better title.
2. one issue for one thing: add service_id as key to plugin limit-*, do you mean this?

[LY-GO]

Sorry,my English not better;one issue : add service_id as key to plugin limit-*,i mean that.

[LY-GO]

1. you need to use a better title.
2. one issue for one thing: add service_id as key to plugin limit-*, do you mean this?
   now i set key in the following way,but service_id is nil.Why is that?
   

[membphis]

I think we can support service_id as key to plugin limit-count first.
so you can update the title of this issue.

after we resolve this issue, you can create more issues for other limit-* plugins.

[membphis]

2. now i set key in the following way,but service_id is nil.Why is that?

do you bind any service to route?

[LY-GO]

2. now i set key in the following way,but service_id is nil.Why is that?

do you bind any service to route?

yes

[LY-GO]

2. now i set key in the following way,but service_id is nil.Why is that?

do you bind any service to route?

we can use core.var.service_id to acquire value of service_id?

[membphis]

this old version dashboard, so it not support service_id as key.

[LY-GO]

this old version dashboard, so it not support service_id as key.

new version supports service_id as key?my version is 1.5,Is there any other version

[membphis]

please make a try with the master branch ^_^

[juzhiyuan]

this old version dashboard, so it not support service_id as key.

new version supports service_id as key?my version is 1.5,Is there any other version

The new dashboard doesn't support the Service module currently.

tracking issue: apache/apisix-dashboard#471

[LY-GO]

please make a try with the master branch ^_^

i still use the master branch

[membphis]

https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L39

plugin limit-count, it has supported using service_id as key in master branch.

which plugin you want to support service_id ?

[LY-GO]

please make a try with the master branch ^_^

I can require service_id from Eureka?