ci: new test case for https health check #10575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
Contributor
|
also fixes: #10218 |
shreemaan-abhishek
requested changes
Dec 1, 2023
t/node/healthcheck-https.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 1: https health check (one healthy node, one unhealthy node) |
Contributor
There was a problem hiding this comment.
Suggested change
| === TEST 1: https health check (one healthy node, one unhealthy node) | |
| === TEST 2: https health check (one healthy node, one unhealthy node) |
Contributor
There was a problem hiding this comment.
please use utils/reindex *.t to reindex the file
Contributor
Author
There was a problem hiding this comment.
why CI not found this ?
t/node/healthcheck-https.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 2: https health check (two unhealthy nodes) |
Contributor
There was a problem hiding this comment.
Suggested change
| === TEST 2: https health check (two unhealthy nodes) | |
| === TEST 3: https health check (two unhealthy nodes) |
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
monkeyDluffy6017
added
the
wait for update
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
monkeyDluffy6017
approved these changes
Dec 4, 2023
Contributor
|
@shreemaan-abhishek please review |
monkeyDluffy6017
added
approved
and removed
wait for update
AlinsRan
approved these changes
Dec 5, 2023
luoluoyuyu
approved these changes
Dec 5, 2023
shreemaan-abhishek
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#9993
Checklist