chore: enhance lago test setup #12868
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
| test_dir: | ||
| - t/plugin/[a-k]* | ||
| - t/stream-plugin t/plugin/[l-z]* | ||
| - t/stream-plugin t/plugin/[l-z]*.t |
Contributor
Author
There was a problem hiding this comment.
needed to fix this unnecessary warning:
Member
There was a problem hiding this comment.
Does the t/plugin/[a-k]* line above not need to be modified?
Contributor
Author
There was a problem hiding this comment.
yes, and I have done that.
| ).resolves.not.toThrow() | ||
| console.log(`[${new Date().toLocaleTimeString()}] created consumer`) | ||
| }); | ||
| }, 5 * 1000); |
Contributor
Author
There was a problem hiding this comment.
this test block was missing a timeout
| local ok, stdout, stderr, reason, status = shell.run([[ $exec_snippet ]], $stdin, @{[($timeout-1)*1000]}, $max_size) | ||
| if not ok then | ||
| ngx.log(ngx.WARN, "failed to execute the script with status: " .. (status or "nil ") .. ", reason: " .. (reason or "nil ") .. ", stderr: " .. (stderr or "nil ")) | ||
| ngx.log(ngx.WARN, "failed to execute the script with status: " .. (status or "nil ") .. ", reason: " .. (reason or "nil ") .. ", stdout: " .. (stdout or "nil ") .. ", stderr: " .. (stderr or "nil ")) |
Contributor
Author
There was a problem hiding this comment.
we found that when shell.run failed the error log line got executed however, the response body was still empty, due to which we were unable to examine the stdout. So we add the stdout to this log line.
nic-6443
previously approved these changes
Jan 7, 2026
dosubot
bot
added
size:XS
nic-6443
approved these changes
Jan 8, 2026
LiteSun
approved these changes
Jan 8, 2026
membphis
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to enhance the reliablity of lago test. Please check comments for detailed information.
Checklist