Skip to content

docs: update http-logger, rocketmq-logger, and syslog plugin docs#13272

Merged
Baoyuantop merged 19 commits into
apache:masterfrom
Yilialinn:docs/update-http-rocketmq-syslog-logger
Apr 28, 2026
Merged

docs: update http-logger, rocketmq-logger, and syslog plugin docs#13272
Baoyuantop merged 19 commits into
apache:masterfrom
Yilialinn:docs/update-http-rocketmq-syslog-logger

Conversation

@Yilialinn
Copy link
Copy Markdown
Contributor

Summary

Update http-logger, rocketmq-logger, and syslog plugin docs:

  • Add canonical links pointing to API7 docs
  • Add complete examples sections from API7 docs (Admin API only)
  • Restructure attributes tables with updated types, defaults, and descriptions
  • Add batch processor attributes (batch_max_size, inactive_timeout, buffer_duration, retry_delay, max_retry_count) to rocketmq-logger and syslog attribute tables
  • Add max_req_body_bytes and max_resp_body_bytes to syslog attribute table
  • Remove Delete Plugin sections
  • Update descriptions to match API7 docs
  • Replace ADMIN_API_KEY with admin_key in all examples

Both EN and ZH docs updated.

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. doc Documentation things labels Apr 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates logging plugin documentation (EN/ZH) to align with API7 docs by adding canonical links, refreshing attributes tables (types/defaults/descriptions), and expanding Admin API examples while removing legacy “delete plugin” sections.

Changes:

  • Added canonical links to API7 Hub pages for multiple plugin docs.
  • Restructured and expanded attributes/metadata sections (including batch-processor-related attributes and body-size limits where applicable).
  • Replaced and expanded example sections with complete Admin API walkthroughs (routes + plugin metadata).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
docs/zh/latest/plugins/syslog.md Canonical link + rewritten description, updated attribute tables, and expanded examples for syslog.
docs/zh/latest/plugins/splunk-hec-logging.md Canonical link + updated attributes/metadata + expanded Splunk setup and usage examples.
docs/zh/latest/plugins/rocketmq-logger.md Canonical link + updated attributes/metadata + expanded RocketMQ docker-compose and usage examples.
docs/zh/latest/plugins/http-logger.md Canonical link + updated attributes/metadata + expanded mockbin-based examples.
docs/zh/latest/plugins/google-cloud-logging.md Canonical link + updated attributes/metadata + expanded auth_config/auth_file examples.
docs/zh/latest/plugins/clickhouse-logger.md Canonical link + updated attributes/metadata + expanded ClickHouse setup and examples.
docs/en/latest/plugins/syslog.md Canonical link + rewritten description, updated attribute tables, and expanded examples for syslog.
docs/en/latest/plugins/splunk-hec-logging.md Canonical link + updated attributes/metadata + expanded Splunk setup and usage examples.
docs/en/latest/plugins/rocketmq-logger.md Canonical link + updated attributes/metadata + expanded RocketMQ docker-compose and usage examples.
docs/en/latest/plugins/http-logger.md Canonical link + updated attributes/metadata + expanded mockbin-based examples.
docs/en/latest/plugins/google-cloud-logging.md Canonical link + updated attributes/metadata + expanded auth_config/auth_file examples.
docs/en/latest/plugins/clickhouse-logger.md Canonical link + updated attributes/metadata + expanded ClickHouse setup and examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/zh/latest/plugins/splunk-hec-logging.md Outdated
Comment thread docs/en/latest/plugins/clickhouse-logger.md Outdated
Comment thread docs/en/latest/plugins/clickhouse-logger.md Outdated
Comment thread docs/zh/latest/plugins/clickhouse-logger.md Outdated
Comment thread docs/zh/latest/plugins/clickhouse-logger.md Outdated
Comment thread docs/zh/latest/plugins/syslog.md Outdated
Comment thread docs/en/latest/plugins/syslog.md Outdated
Comment thread docs/zh/latest/plugins/rocketmq-logger.md Outdated
Comment thread docs/en/latest/plugins/rocketmq-logger.md Outdated
Comment thread docs/en/latest/plugins/splunk-hec-logging.md Outdated
Yilialinn and others added 14 commits April 24, 2026 11:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Yilialinn Yilialinn requested a review from kayx23 April 24, 2026 06:14
| include_req_body_expr | array | False | | | An array of one or more conditions in the form of [lua-resty-expr](https://github.com/api7/lua-resty-expr) expressions. Used when `include_req_body` is true. Request body is only logged when the expressions configured here evaluate to true. |
| include_resp_body | boolean | False | false | | If true, include the response body in the log. |
| include_resp_body_expr | array | False | | | An array of one or more conditions in the form of [lua-resty-expr](https://github.com/api7/lua-resty-expr) expressions. Used when `include_resp_body` is true. Response body is only logged when the expressions configured here evaluate to true. |
| max_req_body_bytes | integer | False | 524288 | greater than or equal to 1 | Maximum request body size in bytes to include in the log. If the request body exceeds this value, it will be truncated. Available in APISIX from 3.16.0. |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default for max_retry_count is documented as 60, but the batch-processor schema (apisix/utils/batch-processor.lua) defines the default as 0, and the rocketmq-logger schema does not override it. Please correct this to 0.

@Yilialinn Yilialinn requested a review from kayx23 April 24, 2026 09:50
Comment thread docs/en/latest/plugins/syslog.md Outdated
Comment thread docs/zh/latest/plugins/syslog.md Outdated
@Yilialinn Yilialinn requested a review from kayx23 April 27, 2026 02:06
@Baoyuantop Baoyuantop merged commit 52cba57 into apache:master Apr 28, 2026
7 checks passed
@Yilialinn Yilialinn deleted the docs/update-http-rocketmq-syslog-logger branch April 28, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Documentation things size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants