test(ai-rate-limiting): add test for instance name containing dots#13316
Merged
nic-6443 merged 1 commit intoApr 30, 2026
Merged
Conversation
Instance names with dots (e.g. model version + IP like 'Qwen3.5-397B-10.249.238.157') should be treated as constant keys by the rate limiting framework, not as ctx.var expressions. This test verifies that the existing key_type='constant' setting in transform_limit_conf() correctly handles such names.
dosubot
Bot
added
the
size:M
There was a problem hiding this comment.
Pull request overview
Adds regression coverage ensuring AI instance names containing dots are handled as constant rate-limiting keys (and not misinterpreted as variable lookups).
Changes:
- Adds a new route setup test using an
ai-proxy-multiinstance name containing dots. - Adds a follow-up request test intended to validate the dotted instance name doesn’t trigger
ctx.varresolution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nic-6443
requested review from
AlinsRan,
Baoyuantop,
membphis,
moonming and
shreemaan-abhishek
moonming
approved these changes
Apr 30, 2026
membphis
approved these changes
Apr 30, 2026
shreemaan-abhishek
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance names with dots (e.g. model version + IP like
Qwen3.5-397B-10.249.238.157) should be treated as constant keys by the rate limiting framework, not asctx.varexpressions.The existing
key_type = "constant"intransform_limit_conf()already handles this correctly. This test adds coverage for the scenario to prevent future regressions.