fix: add fetch_secrets support for ai-rate-limiting, limit-conn, and limit-req plugins#13319
Closed
shreemaan-abhishek wants to merge 2 commits into
Closed
Conversation
…limit-req plugins
Member
|
@shreemaan-abhishek We have a new plan for the secret feature #13312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While testing distributed rate limiting with secret references, I noticed that
ai-rate-limiting,limit-conn, andlimit-reqwere passing literal strings such as"$ENV://REDIS_HOST"to Redis instead of resolving them, even thoughlimit-countalready supported this. The root cause is that those three plugins never invokedapisix.secret.fetch_secretson their config before using it. This change adds the missingfetch_secretscalls in the relevant access/log/instance-status entry points so that$ENV://and$secret://references in fields likeredis_hostare resolved consistently across all rate-limiting plugins.Which issue(s) this PR fixes:
Fixes #
Checklist