Skip to content

fix: add fetch_secrets support for ai-rate-limiting, limit-conn, and limit-req plugins#13319

Closed
shreemaan-abhishek wants to merge 2 commits into
apache:masterfrom
shreemaan-abhishek:feat/secret-refs-for-rate-limit-plugins
Closed

fix: add fetch_secrets support for ai-rate-limiting, limit-conn, and limit-req plugins#13319
shreemaan-abhishek wants to merge 2 commits into
apache:masterfrom
shreemaan-abhishek:feat/secret-refs-for-rate-limit-plugins

Conversation

@shreemaan-abhishek
Copy link
Copy Markdown
Contributor

Description

While testing distributed rate limiting with secret references, I noticed that ai-rate-limiting, limit-conn, and limit-req were passing literal strings such as "$ENV://REDIS_HOST" to Redis instead of resolving them, even though limit-count already supported this. The root cause is that those three plugins never invoked apisix.secret.fetch_secrets on their config before using it. This change adds the missing fetch_secrets calls in the relevant access/log/instance-status entry points so that $ENV:// and $secret:// references in fields like redis_host are resolved consistently across all rate-limiting plugins.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working labels Apr 29, 2026
@nic-6443
Copy link
Copy Markdown
Member

@shreemaan-abhishek We have a new plan for the secret feature #13312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants