Skip to content

fix(admin): require admin key for schema validate endpoint #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreemaan-abhishek merged 1 commit into from
May 7, 2026
Merged

fix(admin): require admin key for schema validate endpoint #13328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apisix/admin/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ end


local function schema_validate()
set_ctx_and_check_token()

local uri_segs = core.utils.split_uri(ngx.var.uri)
core.log.info("uri: ", core.json.delay_encode(uri_segs))

Expand Down
89 changes: 89 additions & 0 deletions t/admin/token.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,92 @@ PUT /apisix/admin/plugins/reload?api_key=4054f7cf07e344346cd3f287985e76a2
--- request
GET /apisix/admin/routes??api_key=4054f7cf07e344346cd3f287985e76a2
--- error_code: 401



=== TEST 10: schema validate without token
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").req_self_with_http
local res, err = t('/apisix/admin/schema/validate/routes',
"POST",
[[{
"uri": "/httpbin/*",
"upstream": {
"scheme": "https",
"type": "roundrobin",
"nodes": {
"nghttp2.org": 1
}
}
}]]
)

ngx.status = res.status
ngx.print(res.body)
}
}
--- request
GET /t
--- error_code: 401



=== TEST 11: schema validate with wrong token
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").req_self_with_http
local res, err = t('/apisix/admin/schema/validate/routes',
"POST",
[[{
"uri": "/httpbin/*",
"upstream": {
"scheme": "https",
"type": "roundrobin",
"nodes": {
"nghttp2.org": 1
}
}
}]],
{apikey = "wrong_key"}
)

ngx.status = res.status
ngx.print(res.body)
}
}
--- request
GET /t
--- error_code: 401



=== TEST 12: schema validate with correct token
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").req_self_with_http
local res, err = t('/apisix/admin/schema/validate/routes',
"POST",
[[{
"uri": "/httpbin/*",
"upstream": {
"scheme": "https",
"type": "roundrobin",
"nodes": {
"nghttp2.org": 1
}
}
}]],
{x_api_key = "edd1c9f034335f136f87ad84b625c8f1"}
)

ngx.status = res.status
ngx.print(res.body)
}
}
--- request
GET /t
--- error_code: 200
Loading