Skip to content

test(ai-aliyun-content-moderation): remove unused mock LLM location#13354

Merged
shreemaan-abhishek merged 1 commit into
apache:masterfrom
janiussyafiq:chore/aliyun-test-remove-dead-mock
May 12, 2026
Merged

test(ai-aliyun-content-moderation): remove unused mock LLM location#13354
shreemaan-abhishek merged 1 commit into
apache:masterfrom
janiussyafiq:chore/aliyun-test-remove-dead-mock

Conversation

@janiussyafiq
Copy link
Copy Markdown
Contributor

Description

The location /v1/chat/completions block on the mock server at port 6724 in t/plugin/ai-aliyun-content-moderation.t is never reached by any of the 44 test blocks (130 subtests) in the file.

Every test that needs an upstream LLM points ai-proxy's override endpoint to either:

  • 127.0.0.1:1980 (the shared X-AI-Fixture test fixture mock), or
  • localhost:7737 (the sse_server_example Go process started by ci/common.sh)

No test points an upstream endpoint at port 6724. Port 6724 is only used as the Aliyun content moderation API mock, which is served by location /. The /v1/chat/completions block is dead code left over from an earlier shape of the test.

Removing it keeps the mock focused on the Aliyun moderation API and reduces noise for future readers.

Verification

Ran the full test file locally before and after the change with sse_server_example listening on port 7737:

  • Before: 130 subtests pass
  • After: 130 subtests pass

No behavior change; pure cleanup.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@janiussyafiq janiussyafiq marked this pull request as ready for review May 11, 2026 22:40
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. tech debt labels May 11, 2026
@shreemaan-abhishek shreemaan-abhishek merged commit 412d31d into apache:master May 12, 2026
19 checks passed
@janiussyafiq janiussyafiq deleted the chore/aliyun-test-remove-dead-mock branch May 12, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files. tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants