fix(ai-proxy-multi): stabilize domain health checks#13441
Merged
nic-6443 merged 4 commits intoMay 27, 2026
Merged
Conversation
dosubot
Bot
added
size:XL
membphis
approved these changes
May 27, 2026
AlinsRan
approved these changes
May 27, 2026
shreemaan-abhishek
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ai-proxy-multi active health checks when a domain endpoint resolves to multiple IPs.
The plugin now builds health check nodes from the full resolved DNS answer set and keeps that set sorted, so changes in DNS answer order do not continuously rebuild the checker. Requests still connect to a selected resolved IP while preserving the original domain authority for the Host header and the hostname-only value for SNI. IPv6 resolved addresses are bracketed when constructing the upstream endpoint.
AWS SigV4 signing now uses the final Host authority when a request connects to a resolved IP, and keeps a single wire Host header to avoid signing or header conflicts.
If every checked node becomes unhealthy and the plugin falls back to the default instance set, stale healthy DNS node state is cleared so the fallback uses the full resolved DNS node set.
This also adds regression coverage for DNS answer order changes, Host header preservation for non-default ports, SigV4 signing with resolved IP connections, and an in-flight active health check probe.