fix(upstream): use cert and key instead of stale ok in mTLS error checks#13442
Open
okaybase wants to merge 1 commit into
Open
fix(upstream): use cert and key instead of stale ok in mTLS error checks#13442okaybase wants to merge 1 commit into
cert and key instead of stale ok in mTLS error checks#13442okaybase wants to merge 1 commit into
Conversation
Baoyuantop
reviewed
May 27, 2026
Contributor
Baoyuantop
left a comment
There was a problem hiding this comment.
The remaining blocker is test coverage. The existing t/node/upstream-mtls.t covers several upstream mTLS schema validation and successful handshake paths, but it does not directly cover the runtime path in apisix/upstream.lua where fetch_cert or fetch_pkey fails and set_by_route should return 503 instead of passing an invalid value to the later TLS setup logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The branch uses a stale
okvariable fromfill_node_info()to check whetherfetch_certandfetch_pkeysucceeded, instead of checking thecertandkeyvariables they actually return. Sinceokwas alreadytrueat that point, both error branches were unreachable — if either fetch returnedfalse, the function would silently proceed with an invalid value rather than returning a 503 error.Checklist