fix(balancer): separate keepalive pool by referenced client cert#13587
Merged
shreemaan-abhishek merged 1 commit intoJun 23, 2026
Merged
Conversation
nic-6443
approved these changes
Jun 22, 2026
membphis
approved these changes
Jun 22, 2026
AlinsRan
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an HTTPS/GRPCS upstream sets its client certificate via
tls.client_cert_id(referencing an SSL object) rather than an inlinetls.client_cert, the keepalive connection pool name did not include any cert identifier.The pool name only appended
tls.client_cert(the inline PEM). For upstreams referencing certs by id, that field is empty, so two upstreams pointing at the same backend host/port/SNI but using differentclient_cert_ids collapsed into the same pool and could reuse each other's already-established TLS connections.This change appends
tls.client_cert_idto the pool name when an inline cert is not present, so connections established with different referenced client certs are kept in separate pools.A regression test in
t/node/upstream-keepalive-pool.tsets up two upstreams to the same backend with differentclient_cert_ids and asserts their connections are not shared (it fails before this change and passes after).Which issue(s) this PR fixes:
Fixes #
Checklist