Skip to content

Conversation

@moonming
Copy link
Member

@moonming moonming commented Aug 6, 2020

What this PR does / why we need it:

fix #1872, which not using the right way to install from luarocks.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@moonming moonming requested review from nic-chen and shuaijinchao and removed request for nic-chen August 6, 2020 01:55

description = {
summary = "Apache APISIX is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
summary = "Apache APISIX(incubating) is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove incubating now.

@moonming
Copy link
Member Author

moonming commented Aug 6, 2020 via email

@nic-chen
Copy link
Member

nic-chen commented Aug 6, 2020

Apache APISIX was an incubator project until version 1.4.1, we don't have to change the historical version Thanks, Ming Wen Twitter: _WenMing nic-chen notifications@github.com 于2020年8月6日周四 上午10:18写道:

@.**** commented on this pull request. ------------------------------ In rockspec/apisix-0.9-0.rockspec <#2003 (comment)>: > @@ -24,7 +24,7 @@ source = { } description = { - summary = "Apache APISIX is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.", + summary = "Apache APISIX(incubating) is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.", we could remove incubating now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2003 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJZBK65VKNF7ALNXKQGQILR7IHHXANCNFSM4PWC5F6Q .

ok

@membphis membphis merged commit 87c252c into apache:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants