feature: implemented plugin log-rotate, rotate log by interval time.
#2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
requested changes
Aug 21, 2020
moonming
requested changes
Aug 25, 2020
Member
Author
|
@nic-chen I think we can merge this PR now |
Member
spacewander
requested changes
Aug 26, 2020
| local prefix = ngx.config.prefix() | ||
|
|
||
| if conf_path then | ||
| local root = string.sub(conf_path, 1, 1) |
Member
There was a problem hiding this comment.
Better to use string.byte(conf_path, 1, 1), and compare it with ascii number.
| local dir = string.sub(conf_path, 1, n) | ||
| local name = string.sub(conf_path, n + 1) | ||
| return dir, name | ||
| end |
Member
There was a problem hiding this comment.
Better to move the stuff above into two function: is_abs and split_path in a utility file so that other people can reuse it.
Member
|
@spacewander We urgently need this feature, I will merge it first, and will deal with the optimization items later. thank you very much. |
nic-chen
approved these changes
Aug 26, 2020
spacewander
approved these changes
Aug 26, 2020
moonming
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title.
Pre-submission checklist: