Skip to content

Conversation

@Yiyiyimu
Copy link
Member

What this PR does / why we need it:

fix #2195

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@Yiyiyimu
Copy link
Member Author

Chinese doc of plugins format needs to be unified。

|max_retry_times|optional |Max number of retry times after a connect to a log server failed or send log messages to a log server failed.|
|retry_interval|optional |The time delay (in ms) before retry to connect to a log server or retry to send log messages to a log server, default to 100 (0.1s).|
|pool_size |optional |Keepalive pool size used by sock:keepalive. Default to 10.|
|include_req_body|optional |Return request body besides head; default is false|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Return request body besides head;"
->
"Whether to include the request body, the default is false, which means it is not included."

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing test case

| buffer_duration |可选的|必须先处理批次中最旧条目的最长期限(以秒为单位),默认值为 5|
| max_retry_count |可选的|从处理管道中移除之前的最大重试次数,默认为 0|
| retry_delay |可选的|如果执行失败,则应延迟执行流程的秒数,默认为 1|
|include_req_body|可选的| 返回请求 body,默认为 false|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look at: #2205 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(kafka-logger): option include_req_body

2 participants