-
Notifications
You must be signed in to change notification settings - Fork 2.8k
move etcd cluster in docker for CI #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think we could run ETCD as a service in github actions. doc about github actions services |
|
Cool, agreed
nic-chen <notifications@github.com>于2020年9月15日 周二下午9:34写道:
I think we could run ETCD as a service in github actions. doc about
github actions services
<https://docs.github.com/en/actions/configuring-and-managing-workflows/about-service-containers>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2225 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBK5EZXAVWYOAIBOORJTSF5UMVANCNFSM4RLNQS4Q>
.
--
Thanks,
Ming Wen
Twitter: _WenMing
|
|
got it
Thanks,
Ming Wen
Twitter: _WenMing
EnableAsync <notifications@github.com> 于2020年9月16日周三 上午11:40写道:
… ***@***.**** commented on this pull request.
------------------------------
In .github/workflows/build.yml
<#2225 (comment)>:
> run: sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl etcd
+ - name: Linux Get dependencies
+ if: matrix.platform == 'ubuntu-18.04' && (matrix.os_name == 'linux_openresty' || matrix.os_name == 'linux_tengine')
+ run: sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl etcd-client
This test example uses the command etcdctl.
https://github.com/apache/apisix/blob/master/t/core/etcd-auth.t#L29
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2225 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBKYFEX6F4H75LTNZAA3SGAXRPANCNFSM4RLNQS4Q>
.
|
We cannot give a command for the container (CMD) to docker when a given service is created. And I've only come up with the same solution as this one so far, any other solutions? |
This reverts commit 2a03206.
|
ping @EnableAsync |
|
@EnableAsync any update? |
updated 😀 |
| etcd --listen-client-urls 'http://0.0.0.0:2379' --advertise-client-urls='http://0.0.0.0:2379' --data-dir ~/etcd-data > /dev/null 2>&1 & | ||
| etcdctl version | ||
| sleep 5 | ||
| # sudo service etcd start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do not need them, we should remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix other similar points.
| sudo luarocks install luacheck > build.log 2>&1 || (cat build.log && exit 1) | ||
|
|
||
| ./utils/install-etcd.sh | ||
| # ./utils/install-etcd.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove too
|
@EnableAsync nice work 👍 |
What this PR does / why we need it:
#2125
move etcd cluster in docker for CI
Pre-submission checklist: