Skip to content

Conversation

@EnableAsync
Copy link
Contributor

What this PR does / why we need it:

#2125
move etcd cluster in docker for CI

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@nic-chen
Copy link
Member

I think we could run ETCD as a service in github actions. doc about github actions services

@moonming
Copy link
Member

moonming commented Sep 15, 2020 via email

@moonming
Copy link
Member

moonming commented Sep 16, 2020 via email

@EnableAsync
Copy link
Contributor Author

I think we could run ETCD as a service in github actions. doc about github actions services

We cannot give a command for the container (CMD) to docker when a given service is created.
https://github.community/t/how-do-i-properly-override-a-service-entrypoint/17435/4

And I've only come up with the same solution as this one so far, any other solutions?
https://github.community/t/job-service-command/16477

@nic-chen
Copy link
Member

ping @EnableAsync

@moonming
Copy link
Member

@EnableAsync any update?

@EnableAsync
Copy link
Contributor Author

@EnableAsync any update?

updated 😀

etcd --listen-client-urls 'http://0.0.0.0:2379' --advertise-client-urls='http://0.0.0.0:2379' --data-dir ~/etcd-data > /dev/null 2>&1 &
etcdctl version
sleep 5
# sudo service etcd start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do not need them, we should remove them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix other similar points.

sudo luarocks install luacheck > build.log 2>&1 || (cat build.log && exit 1)

./utils/install-etcd.sh
# ./utils/install-etcd.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove too

@moonming moonming merged commit 1dfc4cd into apache:master Oct 28, 2020
@moonming
Copy link
Member

@EnableAsync nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants