bugfix: use etcd:watchcancel to reduce connections in etcdv3#2299
Merged
moonming merged 14 commits intoapache:masterfrom Sep 28, 2020
Merged
bugfix: use etcd:watchcancel to reduce connections in etcdv3#2299moonming merged 14 commits intoapache:masterfrom
moonming merged 14 commits intoapache:masterfrom
Conversation
nic-chen
changed the title
membphis
reviewed
Sep 26, 2020
Yiyiyimu
commented
Sep 26, 2020
Comment on lines
-184
to
-187
| if not dir_res.dir then | ||
| return false, self.key .. " is not a dir" | ||
| end | ||
|
|
Member
Author
There was a problem hiding this comment.
Currently I still set dir = true in etcd protocol conversion for consistency between protocols. But I noticed there is only one test case (global.t TEST 3) needs this parameter, so maybe we could remove it
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
…create new client Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
2 tasks
Member
Author
|
Hi @membphis is there something else we should do before merging |
Member
Author
|
ping @moonming it seems good to go |
idbeta
approved these changes
Sep 28, 2020
Contributor
idbeta
left a comment
idbeta
left a comment
There was a problem hiding this comment.
I passed in my local environment
moonming
reviewed
Sep 28, 2020
moonming
approved these changes
Sep 28, 2020
membphis
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix #2295
Pre-submission checklist: