Skip to content

feat: replace timestamp with date and time in GMT format in plugin hmac-auth#2301

Merged
membphis merged 19 commits intoapache:masterfrom
nic-chen:hmac-auth-date
Sep 28, 2020
Merged

feat: replace timestamp with date and time in GMT format in plugin hmac-auth#2301
membphis merged 19 commits intoapache:masterfrom
nic-chen:hmac-auth-date

Conversation

@nic-chen
Copy link
Member

What this PR does / why we need it:

replace timestamp with date and time in GMT format in plugin hmac-auth

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@nic-chen nic-chen requested review from gxthrj and membphis September 24, 2020 07:17
@gxthrj
Copy link
Contributor

gxthrj commented Sep 24, 2020

I hope to change the default value of clock_skew to 0,
it is more useful when migrating, In this way, the client does not need to modify the client call mode.

@nic-chen
Copy link
Member Author

@moonming please take a review again. thanks.

@membphis membphis merged commit c375bd0 into apache:master Sep 28, 2020
@membphis
Copy link
Member

@nic-chen many thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants