bugfix: when service works with upstream that contains a domain name, the merged configuration should not always changing. #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
changed the title
membphis
changed the title
nic-chen
reviewed
Sep 26, 2020
| }, | ||
| "upstream": { | ||
| "nodes": { | ||
| "www.baidu.com:80": 1 |
Member
There was a problem hiding this comment.
seems visit baidu.com unstable in github actions before?
gxthrj
approved these changes
Sep 26, 2020
apisix/init.lua
Outdated
| return_direct, nil) | ||
| local err | ||
| route, err = lru_resolved_domain(route, api_ctx.conf_version, | ||
| parse_domain_in_route, route, api_ctx) |
Contributor
There was a problem hiding this comment.
api_ctx need to be removed ？
Member
Author
There was a problem hiding this comment.
nice, will fix it later
membphis
changed the title
Member
Author
|
@moonming this is an old bug for long time, and it seems that I need more time to fix it. |
Member
|
ok |
… `grpc` module.
membphis
changed the title
nic-chen
approved these changes
Sep 28, 2020
spacewander
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when service works with upstream that contains a domain name, the merged configuration is always changing.
if the configuration is always changing, it won't hit the LRU item, which causes some plugins to work abnormally, such as
limit-req.fix: #2320
Pre-submission checklist: