feat: support to fetch route_id and service_id via ctx.var#2326
Merged
membphis merged 10 commits intoapache:masterfrom Sep 27, 2020
Merged
feat: support to fetch route_id and service_id via ctx.var#2326membphis merged 10 commits intoapache:masterfrom
route_id and service_id via ctx.var#2326membphis merged 10 commits intoapache:masterfrom
Conversation
membphis
requested changes
Sep 26, 2020
Member
membphis
left a comment
membphis
left a comment
There was a problem hiding this comment.
and we need a test case for server_id is nil. eg: the route object not bind any service object.
membphis
requested changes
Sep 27, 2020
membphis
approved these changes
Sep 27, 2020
moonming
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix #2275
Add support to fetch
consumer_nameviactx.var, the way ofconsumer_nameis added by the nextPR, because waiting for #2270 PR merge.Pre-submission checklist: