doc : fixes issue #2327 #2525
Merged
doc : fixes issue #2327 #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Oct 28, 2020
| * [Router radixtree](router-radixtree.md) | ||
| * [Stand Alone Model](stand-alone.md): Supports to load route rules from local yaml file, it is more friendly such as under the kubernetes(k8s). | ||
| * [Stream Proxy](stream-proxy.md) | ||
| * [gRPC Proxy](grpc-proxy.md) |
Member
There was a problem hiding this comment.
Do we need to update the Chinese version?
Contributor
Author
There was a problem hiding this comment.
Addressed this in latest commit.
spacewander
added
the
wait for update
Contributor
Author
|
@moonming @spacewander @membphis Can you please check now? |
spacewander
reviewed
Oct 30, 2020
doc/grpc-proxy.md
Outdated
| --> | ||
|
|
||
| [中文](zh-cn/grpc-proxy.md) | ||
| [Chinese](zh-cn/grpc-proxy.md) |
Member
There was a problem hiding this comment.
It would be better if you leave this unchanged.
Member
|
@tashiya-menuri one for one thing. fix |
Contributor
Author
|
@membphis @spacewander Addressed the requested changes in latest commit. Can you please have a look now? |
moonming
approved these changes
Oct 30, 2020
membphis
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix for #2327