docs: node-status.md#2615
Conversation
|
CI failed, please take a look at the output: https://github.com/apache/apisix/pull/2615/checks?check_run_id=1347360640#step:11:51 |
HelloBug0
left a comment
HelloBug0
left a comment
There was a problem hiding this comment.
Change tabs to spaces
membphis
left a comment
membphis
left a comment
There was a problem hiding this comment.
we can update the English version too
doc/zh-cn/plugins/node-status.md
Outdated
| $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d ' | ||
| { | ||
| "uri": "/route1", | ||
| "methods": ["PUT", "GET"], |
There was a problem hiding this comment.
we can remove this line, it is not important
There was a problem hiding this comment.
Thanks for your comments, and here you mean remove from line 61 to line 81?
There was a problem hiding this comment.
only remove "methods": ["PUT", "GET"], ^_^
There was a problem hiding this comment.
OK, I will remove it now~
doc/zh-cn/plugins/node-status.md
Outdated
|
|
||
| ## 启用插件 | ||
|
|
||
| 1. 配置文件apisix/conf/conf.yaml的plugins list中配置node-status |
There was a problem hiding this comment.
The file name of conf.yaml is incorrect, it should be config.yaml, right?
There was a problem hiding this comment.
yes, I will change it. Thanks~
doc/zh-cn/plugins/node-status.md
Outdated
|
|
||
| ## 插件接口 | ||
|
|
||
| 插件增加接口`/apisix/status`，可通过 [interceptors](plugin-interceptors.md)保护该接口。 |
There was a problem hiding this comment.
Need a space after interceptors.md)
doc/zh-cn/plugins/node-status.md
Outdated
| }' | ||
| ``` | ||
|
|
||
| 发送该请求的前提是apisix/conf/conf.yaml中已经配置node-status，此时node-status插件对该请求处理无影响，所以一般不会将node-status插件设置到路由中。 |
There was a problem hiding this comment.
Do you mean apisix/conf/config.yaml? Also, need spaces between Chinese and English word.
Please fix other similar places in the PR.
|
I miss adding the commment when I commit the document at the third time, sorry about it. |
1. add a blank line after #目录 2. remove some unnecessary lines
1. add language type in code 2. change '插件属性为空' to ‘无’ 3. change '接口插件' to '插件接口' which could add link to directory '插件接口'
|
@HelloBug0 |
|
Tracking issue #2379 |
5 participants
This is the description of plugin node-status in Chinese, and I'd love to submit the document in lEnglish later.
This PR is relate with issue#2379