Skip to content

fix(hmac-auth): when the request contains escape characters, the signature verification fails #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 6 commits into from
Nov 18, 2020
Merged

fix(hmac-auth): when the request contains escape characters, the signature verification fails #2749

spacewander merged 6 commits into from
Nov 18, 2020

Conversation

@Firstsawyou
Copy link
Contributor

@Firstsawyou Firstsawyou commented Nov 15, 2020 •
edited
Loading

fix #2710

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@Firstsawyou Firstsawyou marked this pull request as ready for review November 15, 2020 13:04
spacewander
spacewander reviewed Nov 16, 2020
View reviewed changes
@spacewander spacewander merged commit a6678c3 into apache:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

@membphis membphis membphis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(hmac-auth): when the request contains escape characters, the signature verification fails

3 participants

@Firstsawyou @spacewander @membphis