fix: log index function should use self instead of m or _M
#2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzipeek
changed the title
index functionindex function should use self instead of m or _M
spacewander
requested changes
Nov 19, 2020
| -- cache the lazily generated method in our | ||
| -- module table | ||
| _M[cmd] = method | ||
| self[cmd] = method |
| -- cache the lazily generated method in our | ||
| -- module table | ||
| m[cmd] = method | ||
| self[cmd] = method |
Member
There was a problem hiding this comment.
The m and self are the same in this situation.
Member
|
I don't think we need to waste too much time on such "readable" since everyone has her difference standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It is more reasonable to use
selfvariables than to use_Mormdirectly.Pre-submission checklist: